Allow magclass objects without years #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneskoch94
commented
Aug 1, 2024
There was a problem hiding this comment.
@fbenke-pik Here, I just drop the check. Any potential inconsistency is caught in transform_user_input, at the same location as it is caught when passing a tibble.
johanneskoch94
commented
Aug 1, 2024
There was a problem hiding this comment.
Here, if the magpie object doesn't have year info, then is won't have a year column. That will lead to an error below, if a unit is "current".
fbenke-pik
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of #28, thanks @fbenke-pik !! (In some places the code changes are identical.)
It does the same thing, in a slightly different manner, that I think is more in-line with previous code.
Falk's text, repeated here for clarity:
This extends convertGDP to handle magclass objects with NULL as years dimension (assuming the unit conversion does not require the years for conversion, aka "current"))